Skip to content

chore: Upgrade Go version from 1.21 to 1.24 #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
geowa4 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: Upgrade Go version from 1.21 to 1.24 #83

geowa4 wants to merge 2 commits into from
+5 −114

Conversation

@geowa4
Copy link
Contributor

@geowa4 geowa4 commented Jan 7, 2026

Summary

  • Updates Go version from 1.21 (archived) to 1.24, aligning with OpenShift Kubernetes standards
  • Upgrades golangci-lint from v1.55.0 to v1.62.2 for Go 1.24 compatibility
  • Removes deprecated linters (execinquery, exportloopref) and adds copyloopvar replacement
  • Fixes linting issue in mirror.go (perfsprint)

Test Plan

  • All tests pass (make test)
  • Build succeeds (make build)
  • Linting passes with updated configuration (make lint)
  • Dependencies tidied successfully (make mod)
  • No breaking changes to existing functionality

References

Fixes #81

🤖 Generated with Claude Code

geowa4 and others added 2 commits January 6, 2026 13:41
@geowa4 @claude
remove: Remove servicelogger tool
508dd9f 
Servicelogger has been superseded by the managed-notifications MCP server
(https://github.com/openshift/managed-notifications/tree/master/mcp) and
has not received any updates in a long time. Removing it from the tools
collection to reduce maintenance overhead.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 (1M context) <noreply@anthropic.com>
@geowa4 @claude
chore: upgrade Go version from 1.21 to 1.24
ac1ef25 
- Update go.mod to Go 1.24 and toolchain to go1.24.0
- Bump golangci-lint to v1.62.2 for Go 1.24 compatibility
- Remove deprecated linters (execinquery, exportloopref)
- Add copyloopvar linter
- Fix linting issue in mirror.go (string concatenation)

Fixes openshift#81

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 (1M context) <noreply@anthropic.com>
@openshift-ci openshift-ci bot requested review from tnierman and typeid January 7, 2026 16:47
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 7, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: geowa4
Once this PR has been reviewed and has the lgtm label, please assign dustman9000 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 7, 2026

@geowa4: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/coverage ac1ef25 link true /test coverage
ci/prow/lint ac1ef25 link true /test lint
ci/prow/unit ac1ef25 link true /test unit

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tnierman tnierman Awaiting requested review from tnierman

@typeid typeid Awaiting requested review from typeid

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update Go toolchain from 1.21 to 1.24.0

1 participant

@geowa4